Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] [refactor] Move opengl source files to target locations #5200

Merged
merged 11 commits into from
Jun 17, 2022

Conversation

qiao-bo
Copy link
Contributor

@qiao-bo qiao-bo commented Jun 17, 2022

Related issue = #4832

One of the series of steps to split source files from backends, this PR addresses OpenGL:

  • Move OpenGL runtime files to taichi/runtime/opengl for target opengl_runtime.
  • Move OpenGL program impl files to taichi/runtime/program_impls/opengl for target opengl_program_impl.
  • The remaining files in taichi/backends/opengl (Device API files) belongs to the target opengl_rhi.

The dependency relation is:
opengl_rhi <- opengl_runtime <- opengl_program_impl <- core

@netlify
Copy link

netlify bot commented Jun 17, 2022

Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit 8d67062
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62ac69c8632a0b0009f9073f

@qiao-bo qiao-bo marked this pull request as ready for review June 17, 2022 12:40
@qiao-bo qiao-bo requested review from ailzhang, k-ye and bobcao3 June 17, 2022 12:42
Copy link
Collaborator

@bobcao3 bobcao3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bobcao3 bobcao3 merged commit e8c45b3 into taichi-dev:master Jun 17, 2022
@qiao-bo qiao-bo deleted the gl_prog_impl branch June 18, 2022 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants