Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Improved building on Windows #4925

Merged
merged 6 commits into from
May 10, 2022
+22 −22
Merged

[Build] Improved building on Windows #4925

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7ebf635
Fix Win32 API calls for non-unicode builds
PENGUINLIONG May 6, 2022
179f903
Fix variable names when NDK clang is used in prior
PENGUINLIONG May 6, 2022
8ff48c1
Fixed output directory retargeting
PENGUINLIONG May 7, 2022
69e0a6a
Added CMake option for export core (as a hint)
PENGUINLIONG May 7, 2022
bc70fd3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 7, 2022
d2d4333
Removed `TI_EXPORT_CORE` option
PENGUINLIONG May 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed output directory retargeting
@PENGUINLIONG @taichi-gardener
PENGUINLIONG authored and taichi-gardener committed May 10, 2022
commit 8ff48c188bddc85c1684fc1a238972151239ce06
3 changes: 2 additions & 1 deletion cmake/TaichiExportCore.cmake
View file
Original file line number Diff line number Diff line change
@@ -5,4 +5,5 @@ set(TAICHI_EXPORT_CORE_NAME taichi_export_core)
add_library(${TAICHI_EXPORT_CORE_NAME} SHARED)
target_link_libraries(${TAICHI_EXPORT_CORE_NAME} PRIVATE taichi_isolated_core)
set_target_properties(${TAICHI_EXPORT_CORE_NAME} PROPERTIES
CMAKE_LIBRARY_OUTPUT_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/build")
LIBRARY_OUTPUT_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/build"
ARCHIVE_OUTPUT_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/build")