Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lang] Add better error detection for swizzle patterens #4860

Merged
merged 3 commits into from
Apr 26, 2022

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented Apr 26, 2022

Related issue = #4810

@k-ye k-ye requested a review from neozhaoliang April 26, 2022 07:59
@k-ye k-ye added this to the Taichi v1.0.1 milestone Apr 26, 2022
@netlify
Copy link

netlify bot commented Apr 26, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 68a7e8c
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/6267a74a57b67900099ffa92
😎 Deploy Preview https://deploy-preview-4860--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k-ye k-ye requested a review from strongoier April 26, 2022 08:31
Copy link
Contributor

@neozhaoliang neozhaoliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@neozhaoliang neozhaoliang merged commit 433b0e3 into taichi-dev:master Apr 26, 2022
@k-ye k-ye deleted the swizzles branch April 26, 2022 08:55
k-ye added a commit to k-ye/taichi that referenced this pull request May 5, 2022
)

* [lang] Add better error detection for swizzle patterens

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants