[spirv] Fix int casts #4814
Merged
[spirv] Fix int casts #4814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview canceled.
|
bobcao3
force-pushed
the
bobcao3/fix-spirv-int-casts
branch
from
662cea6 to
5d2ffba
Compare
for more information, see https://pre-commit.ci
k-ye
pushed a commit
to k-ye/taichi
that referenced
this pull request
May 5, 2022
* Fix integral type casting helper in spirv * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4788
The old casting code has a bit of misunderstanding of Spirv's casting operators:
UConvertandSConvertare for same signed-ness bit extending or truncation. Bitcasts are for same width casts between different signed-ness.Also fixes a buffer fill command warning about non-multiple of 4 sizes.