-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lang] Add basic complex arithmetic and add a mandelbrot example #4780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
YuCrazing
suggested changes
Apr 15, 2022
YuCrazing
reviewed
Apr 15, 2022
YuCrazing
reviewed
Apr 15, 2022
Co-authored-by: Yu Zhang <[email protected]>
Co-authored-by: Yu Zhang <[email protected]>
YuCrazing
approved these changes
Apr 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
k-ye
pushed a commit
to k-ye/taichi
that referenced
this pull request
May 5, 2022
…chi-dev#4780) * add basic complex arithmetic in math module, and add a mandelbrot set example * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add basic complex arithmetic in math module, and add a mandelbrot set example * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add basic complex arithmetic in math module, and add a mandelbrot set example * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add basic complex arithmetic in math module, and add a mandelbrot set example * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add basic complex arithmetic in math module, and add a mandelbrot set example * Update mathimpl.py * add complex arithmetic support * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add complex arithmetic support * Update python/taichi/math/_complex.py Co-authored-by: Yu Zhang <[email protected]> * Update python/taichi/math/_complex.py Co-authored-by: Yu Zhang <[email protected]> * Update _complex.py * fix missing int8, uint8 types in cuda backends Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yu Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
cconj
,cmul
,cdiv
,csqrt
functions to themath
module to support basic complex arithmetics, and also add a mandelbrot set animation to the examples list.