[refactor] Merge Kernel.argument_names and argument_annotations #4753
Conversation
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Thanks for your contribution, and let's make CI pass :-)
(since this is the first time I made pr with code modification, I am glad to hear any suggestion from you.(^-^) Thanks again).
You are doing great! A tip from me: you can actually run tests locally to detect potential issues early. See https://docs.taichi.graphics/lang/articles/contributor_guide#run-integration-tests
|
@yuanming-hu @k-ye Thanks for your suggestion. I think I made part of things right this time (modified some tests and passed) but not sure whether everything is correct. If something is wrong, I will fix it later. I think I am being familiar with the whole procedure gradually. Thanks for your time. :-) |
|
@k-ye Sry to bother you again. I hope this time everything is all right. Thanks again:-) |
Related issue = #4749
I create a small class which is
KernelArguments: annotation, nameand mergeKernel.argument_nameandKernel.argument_annotationstogether. I hope to meet the requirements in the issue #4749 . If something is wrong in the pr, please don't hesitate to let me know. I will be appreciate for that.(since this is the first time I made pr with code modification, I am glad to hear any suggestion from you.(^-^) Thanks again).