Introduce --run-build-scripts (-R) to always run build scripts #3555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparation for the upcoming commit where we'll need all the images instead of just the main one when reading the history.
The none output format generates no outputs so there's no need to call finalize_staging().
DaanDeMeyer
force-pushed
the
history
branch
5 times, most recently
from
88388d2 to
0aa1dd1
Compare
behrmann
approved these changes
Feb 26, 2025
DaanDeMeyer
force-pushed
the
history
branch
2 times, most recently
from
0bde66a to
0de6972
Compare
Currently we run "mkosi -t none" in systemd and mkosi-kernel to run the build script(s) without rebuilding the entire image. Using the "none" output format for this purpose is a hack. It also breaks when using History=yes as running mkosi -t none will change the output format in the history after which running mkosi qemu will fail saying it can't boot the "none" output format. Let's introduce a --run-build-scripts argument which will make us always run the build scripts regardless of whether the image has already been built or not. At the same time, remove various behaviors from the "none" format that were solely added to enable the hack of using it to run build scripts without rebuilding the image: - Clean up outputs from the previous build when the "none" output format is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we run "mkosi -t none" in systemd and mkosi-kernel to run
the build script(s) without rebuilding the entire image. Using the
"none" output format for this purpose is a hack. It also breaks when
using History=yes as running mkosi -t none will change the output
format in the history after which running mkosi qemu will fail saying
it can't boot the "none" output format.
Let's introduce a --run-build-scripts argument which will make us always
run the build scripts regardless of whether the image has already been
built or not. At the same time, remove various behaviors from the "none"
format that were solely added to enable the hack of using it to run build
scripts without rebuilding the image:
is used