Add Sysdig SDK #2
Open
+1,729
−706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S3B4SZ17
force-pushed
the
add-sysdig-sdk
branch
2 times, most recently
from
304c06e to
7c11d2e
Compare
Signed-off-by: S3B4SZ17 <[email protected]>
tembleking
reviewed
Jul 1, 2025
.github/workflows/publish.yaml
Outdated
|
|
||
| - name: Run ruff | ||
| run: | | ||
| uvx ruff check --fix --config ruff.toml |
There was a problem hiding this comment.
Let's extract all those targets into a makefile so it's easier to maintain and execute locally.
make lintmake test
...
| run: | | ||
| uv run pytest --cov=. --cov-report=xml | ||
|
|
||
| - name: Extract version |
There was a problem hiding this comment.
Let's split this into a different job that depends on the previous. This way we can execute the previous one locally with act.
.pre-commit-config.yaml
Outdated
| - id: ruff-format | ||
| name: Ruff Format | ||
| description: Format code with ruff. | ||
| entry: bash -c 'uvx ruff format --config ruff.toml' |
There was a problem hiding this comment.
In here we could use the previous mentioned make fmt
| entry: bash -c 'uvx ruff format --config ruff.toml' | ||
| language: system | ||
| stages: ["commit", "push"] | ||
| - id: ruff-check |
CODEOWNERS
Outdated
| # the repo. Unless a later match takes precedence, | ||
| # @S3B4SZ17 @alecron and @sysdiglabs/sysdig-training will be requested for | ||
| # review when someone opens a pull request. | ||
| * @S3B4SZ17 @alecron @sysdiglabs/sysdig-training |
There was a problem hiding this comment.
You don't need to specify the single contributors and just leave the team. It's easier to maintain if there are movements in the org.
| @@ -0,0 +1,287 @@ | |||
| # Exclude a variety of commonly ignored directories. | |||
There was a problem hiding this comment.
IDK if this is required. Let's check without it, because it eases the maintenance.
mateobur
previously approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.