This repository was archived by the owner on Dec 19, 2023. It is now read-only.
Add skip verify cli flag #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Bachschwell <[email protected]>
Signed-off-by: Lukas Bachschwell <[email protected]>
Signed-off-by: Lukas Bachschwell <[email protected]>
Signed-off-by: Lukas Bachschwell <[email protected]>
mweinelt
reviewed
Nov 6, 2023
homeassistant_satellite/__main__.py
Outdated
| @@ -69,6 +69,7 @@ async def main() -> None: | |||
| choices=("http", "https"), | |||
| help="Home Assistant protocol", | |||
| ) | |||
| parser.add_argument("--skipVerify", action="store_true", help="Skip verification of the SSL certificate") | |||
There was a problem hiding this comment.
Suggested change
| parser.add_argument("--skipVerify", action="store_true", help="Skip verification of the SSL certificate") | |
| parser.add_argument("--skip-certificate-verification", action="store_true", help="Skip verification of the SSL certificate") |
Existing arguments use lowercase and dashes in between words, so you should follow that. Even then skip-verify would be too generic IMO.
There was a problem hiding this comment.
made it --skip-verify. you you really want it to extend ? There is not really another thing to confuse it with, apart from that it has a help text
homeassistant_satellite/__main__.py
Outdated
| @@ -235,6 +236,7 @@ async def main() -> None: | |||
| host=args.host, | |||
| protocol=args.protocol, | |||
| port=args.port, | |||
| skipVerify=args.skipVerify, | |||
There was a problem hiding this comment.
Suggested change
| skipVerify=args.skipVerify, | |
| skipVerify=args.skipVerify, |
Python generally uses snake case, not camel case.
Comment on lines
41
to
42
| if skipVerify: | ||
| self._session = aiohttp.ClientSession(connector=aiohttp.TCPConnector(verify_ssl=False)) | ||
| else: | ||
| self._session = aiohttp.ClientSession() | ||
|
|
||
| self._session = aiohttp.ClientSession() |
There was a problem hiding this comment.
Why don't you always pass the negated value to the TCPConnector here?
- snake case - inversion for passing arg to clientconnection Signed-off-by: Lukas Bachschwell <[email protected]>
|
Anything else needed here ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds --skipVerify CLI flag to work with self signed SSL certificates. Fixes #18