This repository was archived by the owner on Dec 19, 2023. It is now read-only.
Allow record_pulseaudio to exit when state.is_running == False #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
state.is_runningbecomes false,record_pulseaudiogets stuck inawait queue.get(), since no chunk will ever arrive. This one-line PR adds a final empty chunk to allowrecord_pulseaudioto exit.This issue was causing homeassistant-satellite to get stuck on my system when a HA connection could not be established at startup (normally the satellite should exit in this case).