Bump skymarshal required cmake version to 3.19 #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-skydio
force-pushed
the
aaron/cmake-17
branch
from
d2d16b4 to
0093362
Compare
aaron-skydio
changed the title
| @@ -54,7 +54,7 @@ function(add_cpp_bindings | |||
| list(APPEND generated_files ${bindings_dir}/cpp/lcmtypes/${package}/${type}.hpp) | |||
| endforeach() | |||
|
|
|||
| add_library(${target_name}_cpp INTERFACE ${generated_files}) | |||
There was a problem hiding this comment.
Ah ok, is this why that target was missing when SYMFORCE_USE_EXTERNAL_LCM=OFF?
There was a problem hiding this comment.
That's my guess yeah (although I haven't actually reproduced and checked)
aaron-skydio
force-pushed
the
aaron/cmake-17
branch
from
0093362 to
7ddb8db
Compare
aaron-skydio
changed the title
aaron-skydio
force-pushed
the
aaron/cmake-17
branch
from
7ddb8db to
966cc5b
Compare
hayk-skydio
approved these changes
May 10, 2022
|
Closed by a3b2dc0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122