Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace old screenshot with new one in HowToGuide for First Pull #75109

Open
parispittman opened this issue Jul 9, 2024 · 7 comments · Fixed by vidhupv/swift#2 · May be fixed by #75220
Open

Replace old screenshot with new one in HowToGuide for First Pull #75109

parispittman opened this issue Jul 9, 2024 · 7 comments · Fixed by vidhupv/swift#2 · May be fixed by #75220
Assignees
@vidhupv
Labels
contributor experience documentation good first issue Good for newcomers task

Comments

@parispittman
Copy link
Member

parispittman commented Jul 9, 2024 •
edited by AnthonyLatsis
Loading

Description

Doc to change: https://github.com/swiftlang/swift/blob/main/docs/HowToGuides/FirstPullRequest.md

The screenshot in this doc is showing apple/swift and it's now swiftlang/swift under submitting a pull request. Good first issue for someone!
Link to image
@parispittman parispittman added bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. triage needed This issue needs more specific labels good first issue Good for newcomers labels Jul 9, 2024
@parispittman parispittman changed the title Replace old screenshot with new one Replace old screenshot with new one in HowToGuide for First Pull Jul 9, 2024
@vidhupv
Copy link
Contributor

vidhupv commented Jul 10, 2024 •
edited
Loading

Hi @parispittman , I would like to start contributing and work on this as my first issue, could you please assign this to me?
The current screenshot has a push ready to be pulled( which I assume has to be there considering its in the section for pull requests) but this feels like a paradox considering I can only send in my first pull request AFTER taking the screenshot. Should I just push a dummy change to take the screenshot? I would appreciate any tips on how to move forward!

@MadGanGithub
Copy link

Hey @parispittman
I would like to work on this issue
Can you assign me?

@abhinav26966
Copy link

Hi, I'm interested in working on this issue and would love to contribute to the project. Could you please assign it to me? @parispittman

@AnthonyLatsis
Copy link
Collaborator

@vidhupv was first.

@AnthonyLatsis AnthonyLatsis added documentation contributor experience task and removed triage needed This issue needs more specific labels bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. labels Jul 10, 2024
@AnthonyLatsis
Copy link
Collaborator

Should I just push a dummy change to take the screenshot?

Yeah, you just need to push a dummy branch to your fork for that button to show up.

vidhupv added a commit to vidhupv/swift that referenced this issue Jul 11, 2024
@vidhupv
Add files via upload
221155f 
Uploading new screenshot to swiftlang/swift/docs to resolve swiftlang#75109 next.
@vidhupv vidhupv mentioned this issue Jul 11, 2024
Merged
vidhupv added a commit to vidhupv/swift that referenced this issue Jul 11, 2024
@vidhupv
Merge pull request #2 from vidhupv/vidhupv-patch-2
06665f6 
Add files via upload to docs in order to resolve swiftlang#75109
vidhupv added a commit to vidhupv/swift that referenced this issue Jul 12, 2024
@vidhupv
Update FAQ.md
94504bd 
Repo name change from apple/swift to swiftlang/swift . A dummy branch to open a pull request and screenshot in order to resolve issue swiftlang#75109 in swiftlang/swift
@vidhupv vidhupv linked a pull request Jul 12, 2024 that will close this issue
Open
@AnthonyLatsis AnthonyLatsis linked a pull request Jul 12, 2024 that will close this issue
Resolves #75109 #75163
Closed
@wesleykebrown
Copy link

Hi, @parispittman. I'm working on my first open source contribution for my software development cohort and I would like to be added to this issue ticket, please.

@AnthonyLatsis
Copy link
Collaborator

Hello Wesley, this issue is already being worked on. See: How do I pick something to work on?. You could try #57499 if you are looking to contribute code as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vidhupv vidhupv

Labels
contributor experience documentation good first issue Good for newcomers task
Projects
None yet
Milestone
No milestone
6 participants
@parispittman @AnthonyLatsis @vidhupv @MadGanGithub @wesleykebrown @abhinav26966