Skip to content

Add newline after consecutive declarations #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented May 24, 2023

Fixes #1612

@kimdv kimdv requested a review from ahoppen as a code owner May 24, 2023 19:03
@kimdv kimdv changed the title Add newline after declarations Add newline after consecutive declarations May 24, 2023
@kimdv kimdv force-pushed the kimdv/add-newline-after-declarations branch from 03faf4e to 1f96ddf Compare June 1, 2023 11:47
@kimdv kimdv requested a review from ahoppen June 1, 2023 11:47
@kimdv kimdv force-pushed the kimdv/add-newline-after-declarations branch 3 times, most recently from 195ed92 to a6b02db Compare June 3, 2023 21:05
@kimdv kimdv requested a review from ahoppen June 3, 2023 21:06
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The Fix-Its to add a newline result in much more swifty code.

@kimdv kimdv force-pushed the kimdv/add-newline-after-declarations branch 2 times, most recently from a6b02db to 301cf8d Compare June 7, 2023 18:14
@kimdv kimdv force-pushed the kimdv/add-newline-after-declarations branch from 82b3dfa to 68560ed Compare June 8, 2023 19:55
@kimdv kimdv requested a review from ahoppen June 8, 2023 19:57
@kimdv kimdv force-pushed the kimdv/add-newline-after-declarations branch 2 times, most recently from 12cfb57 to a8e68f7 Compare June 12, 2023 12:14
@kimdv
Copy link
Contributor Author

kimdv commented Jun 12, 2023

@swift-ci please test

@kimdv kimdv force-pushed the kimdv/add-newline-after-declarations branch from a8e68f7 to 772cd0d Compare June 12, 2023 18:38
kimdv added 3 commits June 13, 2023 12:19
If a diagnostic a single FixIt will be applied. Fix-Its they should be considered mutually exclusive
@kimdv kimdv enabled auto-merge June 13, 2023 10:19
@kimdv kimdv force-pushed the kimdv/add-newline-after-declarations branch from 772cd0d to fc780bc Compare June 13, 2023 10:19
@kimdv
Copy link
Contributor Author

kimdv commented Jun 13, 2023

@swift-ci please test

@kimdv kimdv merged commit cf0c99a into swiftlang:main Jun 13, 2023
@kimdv kimdv deleted the kimdv/add-newline-after-declarations branch June 13, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add newline after } to separate from declarations
2 participants