-
Notifications
You must be signed in to change notification settings - Fork 439
Add newline after consecutive declarations #1698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kimdv
merged 3 commits into
swiftlang:main
from
kimdv:kimdv/add-newline-after-declarations
Jun 13, 2023
Merged
Add newline after consecutive declarations #1698
kimdv
merged 3 commits into
swiftlang:main
from
kimdv:kimdv/add-newline-after-declarations
Jun 13, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
commented
May 24, 2023
Tests/SwiftParserTest/translated/ConsecutiveStatementsTests.swift
Outdated
Show resolved
Hide resolved
ahoppen
reviewed
May 24, 2023
Tests/SwiftParserTest/translated/ConsecutiveStatementsTests.swift
Outdated
Show resolved
Hide resolved
03faf4e
to
1f96ddf
Compare
ahoppen
reviewed
Jun 1, 2023
Tests/SwiftParserTest/translated/ConsecutiveStatementsTests.swift
Outdated
Show resolved
Hide resolved
Tests/SwiftParserTest/translated/ConsecutiveStatementsTests.swift
Outdated
Show resolved
Hide resolved
Tests/SwiftParserTest/translated/ConsecutiveStatementsTests.swift
Outdated
Show resolved
Hide resolved
195ed92
to
a6b02db
Compare
ahoppen
reviewed
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. The Fix-Its to add a newline result in much more swifty code.
Tests/SwiftParserTest/translated/ConsecutiveStatementsTests.swift
Outdated
Show resolved
Hide resolved
a6b02db
to
301cf8d
Compare
ahoppen
reviewed
Jun 7, 2023
82b3dfa
to
68560ed
Compare
12cfb57
to
a8e68f7
Compare
@swift-ci please test |
a8e68f7
to
772cd0d
Compare
ahoppen
approved these changes
Jun 12, 2023
If a diagnostic a single FixIt will be applied. Fix-Its they should be considered mutually exclusive
772cd0d
to
fc780bc
Compare
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1612