Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lldb] Add summary formatter for DefaultActorStorage #10388

Conversation

kastiglione
Copy link

Show the actor's state (idle, scheduled, running, or zombie) as its summary.

Show the actor's state (idle, scheduled, running, or zombie) as its summary.
@kastiglione kastiglione requested a review from a team as a code owner March 31, 2025 22:24
@kastiglione
Copy link
Author

@swift-ci test macOS

@kastiglione
Copy link
Author

@swift-ci test linux

@kastiglione
Copy link
Author

@swift-ci test

Copy link

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor nits

@kastiglione
Copy link
Author

@swift-ci test

@kastiglione kastiglione merged commit b7248c7 into stable/20240723 Apr 3, 2025
2 of 3 checks passed
@kastiglione kastiglione deleted the dl/lldb-Add-summary-formatter-for-DefaultActorStorage branch April 3, 2025 01:32
kastiglione added a commit that referenced this pull request Apr 4, 2025
Show the actor's state (idle, scheduled, running, or zombie) as its summary.


(cherry-picked from commit b7248c7)
kastiglione added a commit that referenced this pull request Apr 4, 2025
Show the actor's state (idle, scheduled, running, or zombie) as its summary.


(cherry-picked from commit b7248c7)
jasonmolenda added a commit to jasonmolenda/llvm-project that referenced this pull request Apr 8, 2025
The test added in "Add summary formatter for DefaultActorStorage (swiftlang#10388)"
is checking the actor's state, but it is failing sometimes.
Temporarily disable until Dave can look into this, to unblock
CI/PR testing.

rdar://148754221
jasonmolenda added a commit to jasonmolenda/llvm-project that referenced this pull request Apr 8, 2025
The test added in "Add summary formatter for DefaultActorStorage (swiftlang#10388)"
is checking the actor's state, but it is failing sometimes.
Temporarily disable until Dave can look into this, to unblock
CI/PR testing.

rdar://148754221
jasonmolenda added a commit that referenced this pull request Apr 8, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* [lldb] Temporarily disable actor state test

The test added in "Add summary formatter for DefaultActorStorage (#10388)"
is checking the actor's state, but it is failing sometimes.
Temporarily disable until Dave can look into this, to unblock
CI/PR testing.

rdar://148754221

* Revert "[lldb] Temporarily disable actor state test"

This reverts commit 937c185.

* [lldb] Temporarily disable actor state test

The test added in "Add summary formatter for DefaultActorStorage (#10388)"
is checking the actor's state, but it is failing sometimes.
Temporarily disable until Dave can look into this, to unblock
CI/PR testing.

rdar://148754221
jasonmolenda added a commit to jasonmolenda/llvm-project that referenced this pull request Apr 8, 2025
* [lldb] Temporarily disable actor state test

The test added in "Add summary formatter for DefaultActorStorage (swiftlang#10388)"
is checking the actor's state, but it is failing sometimes.
Temporarily disable until Dave can look into this, to unblock
CI/PR testing.

rdar://148754221

(cherry picked from commit 0b855f5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants