forked from llvm/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lldb] Add summary formatter for DefaultActorStorage #10388
Merged
kastiglione
merged 3 commits into
stable/20240723
from
dl/lldb-Add-summary-formatter-for-DefaultActorStorage
Apr 3, 2025
Merged
[lldb] Add summary formatter for DefaultActorStorage #10388
kastiglione
merged 3 commits into
stable/20240723
from
dl/lldb-Add-summary-formatter-for-DefaultActorStorage
Apr 3, 2025
+61
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show the actor's state (idle, scheduled, running, or zombie) as its summary.
@swift-ci test macOS |
@swift-ci test linux |
@swift-ci test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some minor nits
@swift-ci test |
kastiglione
added a commit
that referenced
this pull request
Apr 4, 2025
Show the actor's state (idle, scheduled, running, or zombie) as its summary. (cherry-picked from commit b7248c7)
kastiglione
added a commit
that referenced
this pull request
Apr 4, 2025
Show the actor's state (idle, scheduled, running, or zombie) as its summary. (cherry-picked from commit b7248c7)
jasonmolenda
added a commit
to jasonmolenda/llvm-project
that referenced
this pull request
Apr 8, 2025
The test added in "Add summary formatter for DefaultActorStorage (swiftlang#10388)" is checking the actor's state, but it is failing sometimes. Temporarily disable until Dave can look into this, to unblock CI/PR testing. rdar://148754221
jasonmolenda
added a commit
to jasonmolenda/llvm-project
that referenced
this pull request
Apr 8, 2025
The test added in "Add summary formatter for DefaultActorStorage (swiftlang#10388)" is checking the actor's state, but it is failing sometimes. Temporarily disable until Dave can look into this, to unblock CI/PR testing. rdar://148754221
jasonmolenda
added a commit
that referenced
this pull request
Apr 8, 2025
* [lldb] Temporarily disable actor state test The test added in "Add summary formatter for DefaultActorStorage (#10388)" is checking the actor's state, but it is failing sometimes. Temporarily disable until Dave can look into this, to unblock CI/PR testing. rdar://148754221 * Revert "[lldb] Temporarily disable actor state test" This reverts commit 937c185. * [lldb] Temporarily disable actor state test The test added in "Add summary formatter for DefaultActorStorage (#10388)" is checking the actor's state, but it is failing sometimes. Temporarily disable until Dave can look into this, to unblock CI/PR testing. rdar://148754221
jasonmolenda
added a commit
to jasonmolenda/llvm-project
that referenced
this pull request
Apr 8, 2025
* [lldb] Temporarily disable actor state test The test added in "Add summary formatter for DefaultActorStorage (swiftlang#10388)" is checking the actor's state, but it is failing sometimes. Temporarily disable until Dave can look into this, to unblock CI/PR testing. rdar://148754221 (cherry picked from commit 0b855f5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show the actor's state (idle, scheduled, running, or zombie) as its summary.