Fix watching relative dirs in @swc/cli due to change in chokidar@v4
#82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chokidar is no longer globbing as of v4. This means that passing relative URLs no longer watches for changes, e.g. `.` as the filename argument. - Modify `watchSources` to accept additional arguments as needed by `globSources` - Pass arguments to `globSources` to get the source list for chokidar to watch - Give the result to chokidar
🦋 Changeset detectedLatest commit: 0195279 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
kdy1
reviewed
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When watching on
--out-dir,@swc/cliwould compile the sources when a relative path was passed, but watching would immediately exit instead of watch for changes.Chokidar version 4.x removes globbing support, which means that it does not recursively watch unresolved relative paths with either globbing or cwd. The documentation recommends resolving the glob(s) before passing to
watch, and has some examples.Weighing the options, it appeared to be more ergonomic to use
globSourcesto resolve the files to watch rather than create a new method of globbing or directly glob the files. This pull request makes a very small change to the parameters ofwatchSources, as I could not cause the error to occur on individual files and wanted to leave that signature alone. However, when watching on--out-dir, watching would immediately exit as a relative file did not exist and was not being resolved via globbing anymore.This restores the ability to pass relative paths and globs to the
swccommand of@swc/cliand successfully watch for changes of the source files.