Fixes #765. Support zero-length [...rest] params. #780
Conversation
This is a breaking change since it changes the behavior of [...rest] params to additionally match nothing. [...rest] test routes were moved under rest-variable because zero-length support would otherwise conflict with [slug].svelte. A [...rest].svelte was added in place so that comparator would continue to implicitly test ...rest routes against other routes.. A design decision was made that `abc-[...rest]-def.svelte` wouldn't match `abc-/foo/-def`, only `abc-foo/bar-def` (no slashes at edges of [...rest] params within a segment).
|
On re-reading #765 , this only handles [...rest] and doesn't make any optional params otherwise. The support for |
|
One thing I don't understand is the code to support something like |
|
What's blocking the merge on this? Would love to be able to use this functionality. |
|
This would be a breaking change, which can always be a bit of a merge delayer. It removes the ability to have spread routes that only match one or more segment. I don't know whether preserving that should be a goal in particular, and I don't know whether we want to try to instead solve this in a more unified way along with optional regular params. |
|
@Conduitry Got it. Thanks. I was actually looking for this to be implemented and commented on the wrong ticket. #545 Glad to see it was merged and working. :) |
This is a breaking change since it changes the behavior of [...rest] params to additionally match
nothing.
[...rest] test routes were moved under /rest-variable because zero-length support would otherwise conflict with [slug].svelte.
A [...rest].svelte was added in place so that comparator would continue to implicitly test ...rest routes against other routes.
A design decision was made that
abc-[...rest]-def.sveltewouldn't matchabc-/foo/-def, onlyabc-foo/bar-def(no slashes at edges of [...rest] params within a segment).