Fix runtime router handling of encoded query parameters

[bermi]

Hello Sapper team! Thanks for creating this fantastic framework.

I found an issue where a link such as

<a href="/?multiline=multi%0Aline">link</a>

will cause runtime routes to parse the query parameters as

{ multiline: "multi" }

instead of

{ multiline: "multi\nline" }

It looks like [email protected] removed the dependency from URLSearchParams with a custom RegExp to accommodate IE11. Using URLSearchParams prevents this and potentially future query parsing bugs from happening, so this PR tries to use URLSearchParams when available and fixes the old RegExp to allow.

To fix current query parser adding the RegExp/dotAll /s would be sufficient but unfortunately, it does not work on IE11 or FF Android. So the [\s\S]* RegExp tick is used as opposed to .*.

Since URLSearchParams uses iterables, I also had to add dom.iterable to the tsconfig.json file to get the tests passing. Since I am new to TypeScript I am not sure what the implication might be for the final sapper client-side bundle.

I have tested the IE11 code by disabling the URLSearchParams block. Are IE11 tests executed automatically by the CI pipeline before pushing a release?

[ehrencrona]

This makes a lot of sense to me!

I'm fairly sure adding dom.iterable to the tsconfig.json is harmless.

[benmccann]

There are several potentially related bugs open in the tracker: #1179 #1174 #1002. Would this PR fix any of them?

This seems like a good fix. I'm slightly hesitant to merge it because it will make Sapper's code diverge more from SvelteKit's. I expect SvelteKit would not hit this bug because it uses UrlSearchParams. But I think overall it's worth it because it adds a test and it'd be nice to eventually port that test to SvelteKit to prevent a regression there