Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Set Dev Port by config #381

Closed
Crisfole opened this issue Aug 26, 2018 · 1 comment · Fixed by #396
Closed

Set Dev Port by config #381

Crisfole opened this issue Aug 26, 2018 · 1 comment · Fixed by #396

Comments

@Crisfole
Copy link

Doesn't look like overriding the dev port is possible:

sapper/src/api/dev.ts

Line 107 in c5456d3

const dev_port = await ports.find(10000);

Not clear where this.port is set, but I'd love to see devPort treated the same. Makes containing the code easier.
Rich-Harris added a commit that referenced this issue Aug 30, 2018
@Rich-Harris
implement --dev-port flag - fixes #381
54da524
Rich-Harris added a commit that referenced this issue Aug 30, 2018
@Rich-Harris
merge master -> gh-381
3d69d48
@Rich-Harris Rich-Harris mentioned this issue Aug 30, 2018
Merged
@Rich-Harris
Copy link
Member

Good idea! Added a --dev-port flag in 0.18.4 — thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

implement --dev-port flag sveltejs/sapper
2 participants
@Crisfole @Rich-Harris