Handle Code Lens Refresh Request #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoub-benali
commented
Dec 10, 2021
plugin/core/sessions.py
Outdated
| def m_workspace_codeLens_refresh(self, _: Any, request_id: Any) -> None: | ||
| """handles the workspace/codeLens/refresh request""" | ||
| for sv in self.session_views_async(): | ||
| sv.start_code_lenses_async() |
There was a problem hiding this comment.
@rwols is it safe to call start_code_lenses_async each time ?
There was a problem hiding this comment.
Also any idea how to fix error: "SessionViewProtocol" has no attribute "start_code_lenses_async" ?
There was a problem hiding this comment.
Should be fine to call it each time. This already happens on editing the document.
Though you should guard the calls with session.uses_plugin() like the existing places do:
Line 547 in 02d0f32
The type issue can be fixed by declaring start_code_lenses_async method on the SessionViewProtocol interface.
rchl
reviewed
Dec 11, 2021
rchl
approved these changes
Dec 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://microsoft.github.io/language-server-protocol/specifications/specification-3-17/#codeLens_refresh