Panel output/regex fixes. #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed panel result_file_regex:
- one non-space character anchored to line start (captured)
- followed by zero or more arbitrary characters (still captured)
- followed by a colon anchored to line end (not captured)
This is tight enough to skip all other lines. The old regex is too
premissive and matches for example:
" Perhaps you meant one of these:"
which you see a lot with Haskell.
* Fixed line number formatting so that there is at least one space at
line start guaranteed for the result_line_regex to match line
numbers > 9999
* Adjusted file and line regex in syntaxes accordingly
* Fixed multi-line diagnostic indentation (just one more)
rchl
reviewed
Oct 26, 2021
rwols
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message.