Typing client file #384
Merged
Typing client file #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #384 +/- ##
==========================================
+ Coverage 87.46% 87.64% +0.18%
==========================================
Files 10 10
Lines 1651 1668 +17
Branches 149 148 -1
==========================================
+ Hits 1444 1462 +18
Misses 167 167
+ Partials 40 39 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Back from summer holiday! Just finished typing the client file. Sorry for the big diff but at least after that we will have most of the outward facing method typed I think. |
jsamoocha
reviewed
Jul 29, 2023
|
I think it is now ready to go 💯 |
jsamoocha
approved these changes
Jul 30, 2023
lwasser
pushed a commit
to lwasser/stravalib
that referenced
this pull request
Aug 26, 2023
* Type signature of all client method * finish typing all signature in client file * minor fixes * finish typing client * fix stream default param * update changelog * use after_epoch and before_epoch in param dict * minor change in BatchedIterator type annotation --------- Co-authored-by: Jonatan Samoocha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add type annotations to the client file. See #373
Still need to fix a couple small typing error and would be best to address #383
first as it relates to the test that are now failling.
Type of change
Select the statement best describes this pull request.
Does your PR include tests
If you are fixing a bug or adding a feature, we appreciate (but do not require)
tests to support whatever fix of feature you're implementing.
Did you include your contribution to the change log?
changelog.mdis up-to-date.If you are having a hard time getting the tests to run correctly feel free to
ping one of the maintainers here!