-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Svelte: Drop Support for Svelte < 5 #30703
base: next
Are you sure you want to change the base?
Conversation
View your CI Pipeline Execution ↗ for commit 78dfeca.
☁️ Nx Cloud last updated this comment at |
b4945f5
to
4dfec3e
Compare
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
Before | After | Difference | |
---|---|---|---|
Dependency count | 131 | 131 | 0 |
Self size | 23 KB | 23 KB | 🎉 -10 B 🎉 |
Dependency size | 36.55 MB | 36.53 MB | 🎉 -26 KB 🎉 |
Bundle Size Analyzer | Link | Link |
@storybook/sveltekit
Before | After | Difference | |
---|---|---|---|
Dependency count | 139 | 139 | 0 |
Self size | 48 KB | 48 KB | 🎉 -10 B 🎉 |
Dependency size | 39.86 MB | 39.84 MB | 🎉 -26 KB 🎉 |
Bundle Size Analyzer | Link | Link |
@storybook/svelte
Before | After | Difference | |
---|---|---|---|
Dependency count | 103 | 103 | 0 |
Self size | 95 KB | 70 KB | 🎉 -26 KB 🎉 |
Dependency size | 10.63 MB | 10.63 MB | 🎉 -10 B 🎉 |
Bundle Size Analyzer | Link | Link |
1193ce0
to
1371245
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
We also need to:
- Update sandboxes. Currently
svelte-kit/skeleton-js
andsvelte-kit/skeleton-ts
uses Svelte 4 and are disabled. I think we can removesvelte-kit/skeleton-js
andsvelte-kit/prerelease-ts
, and just updatesvelte-kit/skeleton-ts
, do you agree? (we already cover both JS and TS in thesvelte-vite
sandboxes) I can do that, the template needs to use the newsv
CLI. - Remove the usage of the
sveltedoc-parser
package from bothsvelte-vite
andsvelte
, as we have a better way for docgen for Svelte 5.
import { VERSION } from 'svelte/compiler'; | ||
|
||
export let decorator = undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's convert these to the $props()
rune too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please try it? I had a long fourth and back with transforming SlotDecorator
and other files to runes, and for some reason, components weren't rendered anymore. Therefore, I've reverted the change.
Closes #
What I did
sveltedoc-parser
svelte-webpack
preset@storybook/svelte-webpack5
users to upgradeChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>