-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ember: Fix ember-template-compiler
import for ember 6+
#30682
base: next
Are you sure you want to change the base?
Ember: Fix ember-template-compiler
import for ember 6+
#30682
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
will it also work for ember < 6 ? |
View your CI Pipeline Execution ↗ for commit 0734036.
☁️ Nx Cloud last updated this comment at |
Yep, it's backward compatible, at least with version 5 (I've manually tested with this version), but should technically work for older versions as well |
ember-template-compiler
import for ember 6+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Package BenchmarksCommit: No significant changes detected, all good. 👏 |
Hey @valentinpalkovic @shilman, anything missing for merging this? Please let me know if I can help in any way. |
Hi @leoeuclids !! Thanks so much for putting this together. It's currently generating the following CI error. Any ideas?
|
What I did
Added the
.js
extension to theember-template-compiler
import, in theframework-preset-babel-ember.js
file.This change makes it compatible with
ember-source@6
and above while keeping compatibility for older versions.Reasoning
After the
package.json
changed inember-source@6
, it now requires the extension to properly find the file to be imported.Greptile Summary
This PR adds the
.js
extension to the ember-template-compiler import in the Ember framework preset, ensuring compatibility with ember-source@6+ while maintaining support for older versions.code/frameworks/ember/src/server/framework-preset-babel-ember.ts
to include the.js
extension in the import statement for ember-template-compiler💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!