Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(simplelookup): update error message in test #43

Merged
merged 2 commits into from
Nov 14, 2024
Merged

fix(simplelookup): update error message in test #43

merged 2 commits into from
Nov 14, 2024

Conversation

volmedo
Copy link
Member

@volmedo volmedo commented Nov 13, 2024

the test was failing because it was expecting the old error message.

I also fixed a call to fmt.Errorf in dynamoprovidercontexttable.

@volmedo volmedo requested a review from hannahhoward November 13, 2024 18:20
@volmedo volmedo self-assigned this Nov 13, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/aws/dynamoprovidercontexttable.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
pkg/aws/dynamoprovidercontexttable.go 0.00% <0.00%> (ø)

@volmedo volmedo merged commit 4740d59 into main Nov 14, 2024
7 of 8 checks passed
@volmedo volmedo deleted the vic/fix/simplelookup-test branch November 14, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanshaw alanshaw alanshaw approved these changes

@hannahhoward hannahhoward Awaiting requested review from hannahhoward

Assignees

@volmedo volmedo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@volmedo @alanshaw