feat(deploy): seperate shared state #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
force-pushed
the
feat/fix-and-expand-deployment
branch
2 times, most recently
from
f0638c5 to
02c6cc0
Compare
alanshaw
approved these changes
Nov 8, 2024
| @@ -68,7 +68,7 @@ resource "aws_lambda_function" "lambda" { | |||
| NOTIFIER_HEAD_BUCKET_NAME = aws_s3_bucket.notifier_head_bucket.bucket | |||
| NOTIFIER_SNS_TOPIC_ARN = aws_sns_topic.published_advertisememt_head_change.id | |||
| PRIVATE_KEY = aws_ssm_parameter.private_key.name | |||
| PUBLIC_URL = var.public_url | |||
| PUBLIC_URL = aws_apigatewayv2_domain_name.custom_domain.domain_name | |||
There was a problem hiding this comment.
yes, nice I was going to do this...
hannahhoward
force-pushed
the
feat/fix-and-expand-deployment
branch
from
a5ef8a8 to
1991073
Compare
hannahhoward
force-pushed
the
feat/fix-and-expand-deployment
branch
from
1991073 to
0e11fca
Compare
hannahhoward
force-pushed
the
feat/fix-and-expand-deployment
branch
from
3d9000e to
25d997a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
This fixes a bug that comes up with multiple workspaces around the hosted zone so that lives in a seperate workspace. It also adds CI for deploys
Implementation
shared(everyone uses these deploy cvonfigs) andapp-- where most configs live that get deployed on a workspace specific context