feat: publish index claim #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/service/contentclaims/service.go
Outdated
| }, | ||
| ), | ||
| assert.Location.Can(): server.Provide( | ||
| assert.Location, | ||
| func(cap ucan.Capability[assert.LocationCaveats], inv invocation.Invocation, ctx server.InvocationContext) (assert.Unit, receipt.Effects, error) { | ||
| log.Errorf("TODO: implement me") | ||
| return assert.Unit{}, nil, nil | ||
| err := indexer.PublishClaim(context.TODO(), inv) |
There was a problem hiding this comment.
This would be for when we publish our own claims for our own service right?
Cause seperately we have the "CacheClaim" call just for the location commitments manged by others.
There was a problem hiding this comment.
sorry rewind looks like neither this nor the equals claim are implemented?
| break | ||
| } | ||
| if ferr != nil { | ||
| return fmt.Errorf("fetching blob index: %w", err) |
There was a problem hiding this comment.
it seems like if we had a successful fetch, even if another errored, then we can proceed, no?
There was a problem hiding this comment.
No wait, a successul fetch will set ferr to nil, so we will proceed.
|
also you're failing tests at the moment. |
hannahhoward
changed the base branch from
refactor/remove-repeated-service-interface
to
main
hannahhoward
force-pushed
the
feat/publish-index-claim
branch
from
5c65928 to
e467ac1
Compare
remove a panic and get test passing in content claims service for now.
hannahhoward
force-pushed
the
feat/publish-index-claim
branch
from
fa74036 to
6870663
Compare
use extracted go-capabilities library
use extracted go-metadata package
implement equals claim publishing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: add tests