Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix toString(JSONArray) to emit object.toString() values #118

Merged
merged 1 commit into from
May 2, 2015

Conversation

stleary
Copy link
Owner

@stleary stleary commented Apr 19, 2015

Please review and post any questions or concerns.
Might have misplaced the branch notes, which are included here:

What problem does this code solve?
JSONML converts XML to JSONObject or JSONArray objects. The corresponding toString() methods should generate similar XML.

Does the change conflict with the JSON spec?
No

Any changes to the API?
No

Any changes to how the code behaves?
No changes to exception behavior. JSONML.toString(JSONArray) will now include object.toString(), in addition to string, JSONObject, and JSONArray content output. E.G. boolean output. This will change the output for some XML inputs.

Does it break the unit tests?
Yes, but see [https://github.com/stleary/JSON-Java-unit-test/tree/JSONMLTest-for-toString-issue], which will be committed if/when this change is merged.

Should the documentation be updated?
No

@stleary
Copy link
Owner Author

stleary commented May 2, 2015

No one has posted comments or concerns, so this change will be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant