Memoize Cartesian ID #159
Merged
Memoize Cartesian ID #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stevenpetryk
approved these changes
May 10, 2024
benchristel
added a commit
to Khan/perseus
that referenced
this pull request
May 22, 2024
0.18.6 demands node version 20.11 or higher, which we don't yet have everywhere (e.g. webapp's Jenkins server runs 20.5). By downgrading, we lose a couple features we submitted: - stevenpetryk/mafs#159 - stevenpetryk/mafs#160 However, I think temporarily sacrificing these features is an okay tradeoff, because otherwise we cannot release Perseus into webapp. Longer term, we may be able to convince Steven (the Mafs maintainer) to relax the node version constraint to something like `>= 20`. I don't think Mafs actually needs 20.11 specifically. Issue: none Test plan: - Release a new version of Perseus - Upgrade Perseus in webapp - All tests should pass on webapp CI
benchristel
added a commit
to Khan/perseus
that referenced
this pull request
May 23, 2024
## Summary: 0.18.6 demands node version 20.11 or higher, which we don't yet have everywhere (e.g. webapp's Jenkins server runs 20.5). By downgrading, we lose a couple features we submitted: - stevenpetryk/mafs#159 - stevenpetryk/mafs#160 However, I think temporarily sacrificing these features is an okay tradeoff, because otherwise we cannot release Perseus into webapp. Longer term, we may be able to convince Steven (the Mafs maintainer) to relax the node version constraint to something like `>= 20`. I don't think Mafs actually needs 20.11 specifically. Issue: none Test plan: - Release a new version of Perseus - Upgrade Perseus in webapp - All tests should pass on webapp CI Author: benchristel Reviewers: nishasy, #perseus, jeremywiebe, mark-fitzgerald Required Reviewers: Approved By: nishasy Checks: ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage (ubuntu-latest, 20.x), ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per our Discord conversation regarding this PR, submitting a fix to memoize Cartesian's ID (the same way it's memoized in Vector).