Make line stroke style overridable #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontrol/override it
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stevenpetryk
approved these changes
Apr 25, 2024
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We noticed that the dashed line style for Mafs lines varied some across the different lines it draws. The
stroke-dasharrayprop value was also hard-coded in the components and so couldn't be adjusted by a consuming application.This PR adjusts all (except
Plot.Inequalities) lines to use a CSS variable for the dash style.Test plan:
Edit the line examples in
docs/components/guide-examples/LinePointSlopeExample.tsx(for example) to usestyle="dashed"for the line.yarn startCheck the line dash style