chore(repo): pivot releases to creating a pr #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moving back to draft, all my testing info/steps got swallowed 😢 |
2 tasks
christian-bromann
approved these changes
Mar 18, 2024
alicewriteswrongs
approved these changes
Mar 18, 2024
as mentioned in #15, it turns out our branch protections will prevent us from pushing to `main` in a github action. in the interest of time and to provide some release consistency to the rest of the team, this commmit pivots the existing `release-prod` workflow to a workflow that will only create a pull request that bumps the version of the project. in a separate commit/pr, we shall introduce a new workflow to do the actual publish
rwaskiewicz
force-pushed
the
rw/create-pr-for-release
branch
from
b153c4c to
a0fc617
Compare
rwaskiewicz
added a commit
that referenced
this pull request
Mar 18, 2024
in #20, this was accidentally left with its old name
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
see 'new behavior' section
GitHub Issue Number: N/A
What is the new behavior?
as mentioned in #15, it turns out our branch protections will prevent us from pushing to
mainin a github action.in the interest of time and to provide some release consistency to the rest of the team, this commmit pivots the existing
release-prodworkflow to a workflow that will only create a pull request that bumps the version of the project.in a separate commit/pr, we shall introduce a new workflow to do the actual publish
Documentation
Updated the release steps for this half of the release only
Does this introduce a breaking change?
Testing
I used 5c099bf to test this PR. I couldn't rename the workflow and run it simultaneously (without adding a
pushtrigger to it). I moved it in the subsequent commit, but it should work just as well once this lands. I opted for this testing method to be able to hit "Run Workflow" in the GH Actions UI, rather than overriding the inputs to the workflow/assuming they worked.I was able to use the aforementioned commit to run the workflow (logs) to generate a PR - #21
Other information