Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wallet)_: token related types moved from the token to tokentypes package #6397

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

saledjenic
Copy link
Contributor

@saledjenic saledjenic commented Mar 7, 2025

This change is needed for the upcoming PR, which will auto-refresh token lists.

The following types are moved from services/wallet/token to services/wallet/token/types location:

  • Token
  • StorageToken
  • TokenMarketValues
  • ChainBalance

@status-im-auto
Copy link
Member

status-im-auto commented Mar 7, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 50c78ab #1 2025-03-07 10:12:46 ~2 min ios 📦zip
✔️ 50c78ab #1 2025-03-07 10:13:04 ~3 min android 📦aar
✔️ 50c78ab #1 2025-03-07 10:14:03 ~4 min macos 📦zip
✔️ 50c78ab #1 2025-03-07 10:15:25 ~5 min linux 📦zip
✔️ 50c78ab #1 2025-03-07 10:15:31 ~5 min macos 📦zip
✔️ 50c78ab #1 2025-03-07 10:16:09 ~6 min windows 📦zip
✔️ 50c78ab #1 2025-03-07 10:29:04 ~19 min tests-rpc 📄log
✔️ 50c78ab #1 2025-03-07 10:42:17 ~32 min tests 📄log
✔️ de0da7b #2 2025-03-07 14:02:26 ~3 min android 📦aar
✔️ de0da7b #2 2025-03-07 14:02:29 ~3 min ios 📦zip
✔️ de0da7b #2 2025-03-07 14:03:46 ~4 min windows 📦zip
✔️ de0da7b #2 2025-03-07 14:05:05 ~5 min macos 📦zip
✔️ de0da7b #2 2025-03-07 14:05:29 ~6 min macos 📦zip
✔️ de0da7b #2 2025-03-07 14:05:47 ~6 min linux 📦zip
✔️ de0da7b #2 2025-03-07 14:16:35 ~17 min tests-rpc 📄log
✔️ de0da7b #2 2025-03-07 14:31:42 ~32 min tests 📄log

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 89.64497% with 35 lines in your changes missing coverage. Please review.

Project coverage is 61.01%. Comparing base (80e6629) to head (de0da7b).

Files with missing lines Patch % Lines
services/wallet/token/token.go 73.17% 11 Missing ⚠️
services/wallet/api.go 16.66% 5 Missing ⚠️
services/wallet/token/analyzer/main.go 0.00% 5 Missing ⚠️
services/wallet/router/router_helper.go 33.33% 4 Missing ⚠️
services/wallet/onramp/provider_mercuryo.go 0.00% 2 Missing ⚠️
...allet/router/pathprocessor/processor_bridge_hop.go 0.00% 2 Missing ⚠️
services/wallet/token/downloader/main.go 0.00% 2 Missing ⚠️
services/wallet/transfer/testutils.go 50.00% 2 Missing ⚠️
protocol/communities/manager.go 0.00% 1 Missing ⚠️
...es/wallet/router/pathprocessor/processor_erc721.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6397      +/-   ##
===========================================
+ Coverage    60.96%   61.01%   +0.05%     
===========================================
  Files          874      875       +1     
  Lines       112418   112418              
===========================================
+ Hits         68534    68596      +62     
+ Misses       35897    35862      -35     
+ Partials      7987     7960      -27     
Flag Coverage Δ
functional 22.64% <56.49%> (+0.05%) ⬆️
unit 59.31% <84.91%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
services/wallet/activity/activity_v2.go 74.01% <100.00%> (ø)
services/wallet/reader.go 78.71% <100.00%> (ø)
services/wallet/requests/router_input_params.go 22.91% <ø> (ø)
services/wallet/router/router.go 75.54% <100.00%> (ø)
services/wallet/router/router_test_data.go 100.00% <100.00%> (ø)
services/wallet/router/routes/router_path.go 86.17% <100.00%> (ø)
services/wallet/token/aave_tokenstore.go 100.00% <100.00%> (ø)
services/wallet/token/balance_persistence.go 76.78% <100.00%> (ø)
services/wallet/token/tokenstore.go 100.00% <100.00%> (ø)
services/wallet/token/types/token.go 100.00% <100.00%> (ø)
... and 11 more

... and 32 files with indirect coverage changes

@saledjenic saledjenic requested a review from shivekkhurana March 7, 2025 11:47
@saledjenic saledjenic changed the title chore(wallet): token related types moved from the token to tokentypes package chore(wallet)_: token related types moved from the token to tokentypes package Mar 7, 2025
…s package

Moved types:
- `Token`
- `StorageToken`
- `TokenMarketValues`
- `ChainBalance`
@saledjenic saledjenic force-pushed the chore/move-token-types branch from 50c78ab to de0da7b Compare March 7, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants