Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(analytics): Add UserID field to MetricsInfo #6385

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ilmotta
Copy link
Contributor

@ilmotta ilmotta commented Mar 4, 2025

Summary

This PR adds a new field to MetricsInfo so that clients can access the MixPanel User ID value from mobile/status.go#InitializeApplicationResponse and allow devs/QAs to easily copy MixPanel User ID in PR builds.

For a better explanation on the problem and solution, please refer to the mobile PR status-im/status-mobile#22235 and its associated issue status-im/status-mobile#21680.

@ilmotta ilmotta self-assigned this Mar 4, 2025
Copy link

github-actions bot commented Mar 4, 2025

We require commits to follow the Conventional Commits, but with _ for non-breaking changes.
Please fix these commit messages:

chore(analytics): Add UserID field to MetricsInfo

@status-im-auto
Copy link
Member

status-im-auto commented Mar 4, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 2d4ba44 #1 2025-03-04 20:19:58 ~2 min ios 📦zip
✔️ 2d4ba44 #1 2025-03-04 20:20:13 ~2 min android 📦aar
✔️ 2d4ba44 #1 2025-03-04 20:21:15 ~3 min macos 📦zip
✔️ 2d4ba44 #1 2025-03-04 20:22:33 ~5 min macos 📦zip
✔️ 2d4ba44 #1 2025-03-04 20:23:05 ~5 min windows 📦zip
✔️ 2d4ba44 #1 2025-03-04 20:23:21 ~6 min linux 📦zip
✔️ 2d4ba44 #1 2025-03-04 20:32:55 ~15 min tests-rpc 📄log
✖️ 2d4ba44 #1 2025-03-04 20:36:20 ~18 min tests 📄log

Copy link
Member

@seanstrom seanstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff, I like it ✅
Do you think we can also a tiny test for this code too?
Maybe something here so we know it's consistently populated later on.

Copy link
Collaborator

@igor-sirotin igor-sirotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants