Group multiple declarations into the same AST node #1207
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes stan-dev/stan#2610
It does 3 things:
int a, b;
are stored in the same AST node, much like in Clang's C++ AST: https://stackoverflow.com/questions/41339220/clang-ast-visitor-for-single-line-multiple-variable-declaration. This saves some memory and allows the following two bulletsint a, b;
intoint a; int b;
but rather preserves the original syntax. (this is quite a nice benefit, see the test output)Other than the parsing and pretty-printing changes, all behavior is the same. The MIR works as before, where each item is split into its own vardecl statement.
Submission Checklist
Release notes
The pretty-printer now preserves multiple declarations in one line like
int a, b;
rather than splitting them into two declarations.Declarations are now allowed in places they previously would not parse, such as the only statement in the body of an if statement.
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)