Fix additions and add GHA R CMD CHECK

[andrjohns]

Duplicate of #88, but with the base branch coming from stan-dev/rstantools rather than my fork, to allow the Github Actions to run

[jgabry]

Awesome, thanks! I can confirm that I don't get the error on my computer when I run things locally but it's great to have GHA checks. Thanks for setting that up.

[andrjohns]

Hmm for some reason the tests are hanging on the Windows run, but I can't reproduce locally. Will see if I can find a fix

[jgabry]

Hmm for some reason the tests are hanging on the Windows run, but I can't reproduce locally. Will see if I can find a fix

Yeah that's strange. Thanks for working on this

[andrjohns]

It looks like it's hanging specifically at the final linking stage when creating and compiling a package, but only for Windows:

   C:/rtools40/mingw64/bin/g++ -shared -s -static-libgcc -o rstanlm.dll tmp.def RcppExports.o stanExports_lm.o -LD:/a/_temp/Library/RcppParallel/lib/x64 -ltbb -ltbbmalloc -LD:/a/_temp/Library/RcppParallel/lib/x64 -Wl,-rpath,D:/a/_temp/Library/RcppParallel/lib/x64 -ltbb -ltbbmalloc -LC:/R/bin/x64 -lR

Very weird.

[jgabry]

It looks like it's hanging specifically at the final linking stage when creating and compiling a package, but only for Windows:

   C:/rtools40/mingw64/bin/g++ -shared -s -static-libgcc -o rstanlm.dll tmp.def RcppExports.o stanExports_lm.o -LD:/a/_temp/Library/RcppParallel/lib/x64 -ltbb -ltbbmalloc -LD:/a/_temp/Library/RcppParallel/lib/x64 -Wl,-rpath,D:/a/_temp/Library/RcppParallel/lib/x64 -ltbb -ltbbmalloc -LC:/R/bin/x64 -lR

Very weird.

@andrjohns So this is just happening on Windows with GHA but not on your local Windows system?

@bgoodri Any ideas what's going wrong here?

[hsbadr]

Very weird.

This looks like a GHA issue, not related to rstantools or this PR. Try to change the version of the actions (e.g., r-lib/actions/setup-r@master instead of r-lib/actions/setup-r@v1) or test the workflow at a different time (sometimes GHA for R fails in the morning or at night).

[andrjohns]

I wasn't able to figure out why it was hanging on the windows GHA, so have just removed for now. The new actions will test on Ubuntu & MacOS, which is still more than the previous Travis tests (just linux).

[andrjohns]

@jgabry Would this be all good to go? Once it's out to CRAN I can submit patches to some packages for 2.26+ compatibility

[hsbadr]

We need to merge this to fix the master branch for rstan >= 2.26.