Allow users to specify lib & include paths for all dependencies #2834
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| name: System Libraries | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ develop, master ] | ||
| push: | ||
| branches: [ develop ] | ||
| paths-ignore: | ||
| - 'doygen/**' | ||
| - 'hooks/**' | ||
| - 'licenses/**' | ||
| - 'LICENSE.md' | ||
| - 'README.md' | ||
| - 'RELEASE-NOTES.txt' | ||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| system-libraries-fwd-mix: | ||
| permissions: | ||
| actions: write # for n1hility/cancel-previous-runs to create & stop workflow runs | ||
| contents: read # for actions/checkout to fetch code | ||
| name: System Library Linking - fwd and non-fun mix tests | ||
| runs-on: ubuntu-22.04 | ||
|
|
||
| steps: | ||
| - uses: n1hility/cancel-previous-runs@v2 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| if: "!startsWith(github.ref, 'refs/tags/') && github.ref != 'refs/heads/master' && github.ref != 'refs/heads/develop'" | ||
|
|
||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-python@v4 | ||
| - name: Install system libraries | ||
| run: | | ||
| # Eigen version in 22.04 repos (3.4) not yet compatible with Stan, | ||
| # manually install 3.3.9 from Debian repositories | ||
| wget http://ftp.de.debian.org/debian/pool/main/e/eigen3/libeigen3-dev_3.3.9-2_all.deb | ||
| sudo dpkg -i ./libeigen3-dev_3.3.9-2_all.deb | ||
| sudo apt-get install -y libboost-all-dev libtbb-dev libsundials-dev ocl-icd-libopencl1 ocl-icd-opencl-dev opencl-c-headers opencl-clhpp-headers | ||
| echo "EIGEN_INC=/usr/include/eigen3/" >> make/local | ||
| echo "BOOST_INC=/usr/include/" >> make/local | ||
|
There was a problem hiding this comment. [BOOST_INC]: this should just be There was a problem hiding this comment. This is missing the proper include directory. |
||
| echo "TBB_INC=/usr/include/" >> make/local | ||
|
There was a problem hiding this comment. [TBB_INC]: this is the same as the |
||
| echo "TBB_LIB=/usr/lib/86_64-linux-gnu" >> make/local | ||
|
There was a problem hiding this comment. this looks wrong for the TBB include library (By inspection). An example from doxygen:
I'd expect there to be a TBB somewhere. |
||
| echo "SUNDIALS_INC=/usr/include" >> make/local | ||
| echo "SUNDIALS_LIB=/usr/lib/x86_64-linux-gnu" >> make/local | ||
| echo "OPENCL_INC=/usr/include/" >> make/local | ||
|
There was a problem hiding this comment. [OPENCL_INC]: this should just be |
||
| echo "OPENCL_LIB=/usr/lib/x86_64-linux-gnu" >> make/local | ||
|
There was a problem hiding this comment. [OPENCL_LIB]: should we just use the existing LDLIBS_OPENCL variable? You can just specify the link libraries directly. |
||
| echo "STAN_OPENCL=true" >> make/local | ||
| - name: Run fwd and non-fun mix tests | ||
| run: | | ||
| python runTests.py -j2 test/unit/math/fwd | ||
| python runTests.py -j2 test/unit/math/mix/core | ||
| python runTests.py -j2 test/unit/math/mix/functor | ||
| python runTests.py -j2 test/unit/math/mix/meta | ||
| python runTests.py -j2 test/unit/math/mix/prob | ||
| python runTests.py -j2 test/unit/math/mix/*_test.cpp | ||
| - name: Upload gtest_output xml | ||
| uses: actions/upload-artifact@v3 | ||
| if: failure() | ||
| with: | ||
| name: gtest_outputs_xml | ||
| path: '**/*_test.xml' | ||
| system-libraries-rev: | ||
| permissions: | ||
| actions: write # for n1hility/cancel-previous-runs to create & stop workflow runs | ||
| contents: read # for actions/checkout to fetch code | ||
| name: System Library Linking - rev tests | ||
| runs-on: ubuntu-22.04 | ||
|
|
||
| steps: | ||
| - uses: n1hility/cancel-previous-runs@v2 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| if: "!startsWith(github.ref, 'refs/tags/') && github.ref != 'refs/heads/master' && github.ref != 'refs/heads/develop'" | ||
|
|
||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-python@v4 | ||
| - name: Install system libraries | ||
| run: | | ||
| # Eigen version in 22.04 repos (3.4) not yet compatible with Stan, | ||
| # manually install 3.3.9 from Debian repositories | ||
| wget http://ftp.de.debian.org/debian/pool/main/e/eigen3/libeigen3-dev_3.3.9-2_all.deb | ||
| sudo dpkg -i ./libeigen3-dev_3.3.9-2_all.deb | ||
| sudo apt-get install -y libboost-all-dev libtbb-dev libsundials-dev ocl-icd-libopencl1 ocl-icd-opencl-dev opencl-c-headers opencl-clhpp-headers | ||
| echo "EIGEN_INC=/usr/include/eigen3/" >> make/local | ||
|
There was a problem hiding this comment. Why are these repeated from above? |
||
| echo "BOOST_INC=/usr/include/" >> make/local | ||
| echo "TBB_INC=/usr/include/" >> make/local | ||
| echo "TBB_LIB=/usr/lib/86_64-linux-gnu" >> make/local | ||
| echo "SUNDIALS_INC=/usr/include" >> make/local | ||
| echo "SUNDIALS_LIB=/usr/lib/x86_64-linux-gnu" >> make/local | ||
| echo "OPENCL_INC=/usr/include/" >> make/local | ||
| echo "OPENCL_LIB=/usr/lib/x86_64-linux-gnu" >> make/local | ||
| echo "STAN_OPENCL=true" >> make/local | ||
| - name: Run rev tests | ||
| run: | | ||
| python runTests.py -j2 test/unit/math/rev | ||
| - name: Upload gtest_output xml | ||
| uses: actions/upload-artifact@v3 | ||
| if: failure() | ||
| with: | ||
| name: gtest_outputs_xml | ||
| path: '**/*_test.xml' | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[EIGEN_INC]: We don't need a new variable. This is literally the existing
EIGENmake variable. Unless we want this to be renaming all the includes.