-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use CVODES error string instead of numeric flag in error messages #2620
Conversation
@syclik do you want to take a look of this one? |
…4.1 (tags/RELEASE_600/final)
…4.1 (tags/RELEASE_600/final)
…4.1 (tags/RELEASE_600/final)
@wds15 would you like to review it? thx |
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
This is ready for review. @SteveBronder @rok-cesnovar any of you have time for this? It's a straightforward impl. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this is a great improvement of the current state. Thanks @yizhang-yiz!
I commented in a few spots that things could be slightly improved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Will probably take a day or a few to get Jenkins tests to pass again. Merge whenever the green light is back.
thanks a lot @rok-cesnovar |
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
This PR addresses #1039 by replacing flag with strings from CVODES.
Summary
The replacement happens inside the checking functions. With added
cvodes_check
we call the library functions that map flag to error string constant.Tests
All CVODES unit tests with error throw checks.
Side Effects
na
Release notes
More informative error messages for ODE solvers.
Checklist
Math issue Add better error handling for CVODES #1039.
Copyright holder: Metrum Research Group
By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit
)make test-headers
)make test-math-dependencies
)make doxygen
)make cpplint
)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested