Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue update sundials 561 #2283

Merged
merged 6 commits into from
Jan 2, 2021

Conversation

wds15
Copy link
Contributor

@wds15 wds15 commented Jan 1, 2021

Summary

Update Sundials to 5.6.1

Tests

No new tests

Side Effects

Nope

Release notes

Upgrade Sundials to 5.6.1

Checklist

  • Math issue upgrade sundials #2282

  • Copyright holder: Sebastian Weber

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@stan-buildbot
Copy link
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 3.4 3.47 0.98 -2.19% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 0.99 -0.91% slower
eight_schools/eight_schools.stan 0.11 0.11 0.99 -1.4% slower
gp_regr/gp_regr.stan 0.15 0.15 1.0 -0.25% slower
irt_2pl/irt_2pl.stan 5.2 5.13 1.01 1.35% faster
performance.compilation 91.57 90.06 1.02 1.65% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 8.64 8.64 1.0 -0.07% slower
pkpd/one_comp_mm_elim_abs.stan 29.48 28.73 1.03 2.53% faster
sir/sir.stan 134.15 137.79 0.97 -2.71% slower
gp_regr/gen_gp_data.stan 0.04 0.04 0.99 -1.45% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.07 3.17 0.97 -3.2% slower
pkpd/sim_one_comp_mm_elim_abs.stan 0.39 0.37 1.05 5.21% faster
arK/arK.stan 2.51 2.51 1.0 0.17% faster
arma/arma.stan 0.61 0.62 0.99 -0.72% slower
garch/garch.stan 0.67 0.68 0.99 -0.68% slower
Mean result: 0.998674169556

Jenkins Console Log
Blue Ocean
Commit hash: e883b1a


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks.

@rok-cesnovar rok-cesnovar merged commit be49360 into develop Jan 2, 2021
@rok-cesnovar rok-cesnovar deleted the feature/issue-update-sundials-561 branch January 2, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants