-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenCL: rev support for trigonometric functions #2259
Conversation
…4.1 (tags/RELEASE_600/final)
…4.1 (tags/RELEASE_600/final)
…4.1 (tags/RELEASE_600/final)
#include <gtest/gtest.h> | ||
#include <test/unit/math/opencl/util.hpp> | ||
|
||
auto acos_functor = [](const auto& a) { return stan::math::acos(a).eval(); }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for eval.
auto acos_functor = [](const auto& a) { return stan::math::acos(a).eval(); }; | |
auto acos_functor = [](const auto& a) { return stan::math::acos(a); }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for other tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Co-authored-by: Tadej Ciglarič <[email protected]>
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
Summary
This PR adds /rev OpenCL support for acos, acosh, asin, asinh, atan, atanh, cos, cosh, sin, sinh, tan, tanh
Tests
/
Side Effects
/
Release notes
OpenCL: added /rev support for acos, acosh, asin, asinh, atan, atanh, cos, cosh, tan, tanh
Checklist
Math issue Implement matrix_cl overloads for prim & rev functions #1854
Copyright holder: Rok Češnovar, Uni. of Ljubljana