Add OpenCL/prim add_diag, diag_matrix, subtract and minor OpenCL fixes #2250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use prim util in add tests
…4.1 (tags/RELEASE_600/final)
t4c1
requested changes
Dec 9, 2020
| @@ -185,7 +185,10 @@ class binary_operation : public operation_cl<Derived, T_res, T_a, T_b> { | |||
| } | |||
|
|
|||
| ADD_BINARY_OPERATION(addition_, operator+, common_scalar_t<T_a COMMA T_b>, "+"); | |||
| ADD_BINARY_OPERATION(subtraction_, operator-, common_scalar_t<T_a COMMA T_b>, | |||
| ADD_BINARY_OPERATION(addition_operator_, add, common_scalar_t<T_a COMMA T_b>, "+"); | |||
There was a problem hiding this comment.
You have the class names for addition aroud - the other one is operator. Also it might be better to add a wrapper function for add to delegate to operator instead of constructing another class
| @@ -33,8 +33,7 @@ inline void check_diagonal_zeros(const char* function, const char* name, | |||
| cl::Context ctx = opencl_context.context(); | |||
| try { | |||
| int zero_on_diagonal_flag = 0; | |||
| matrix_cl<int> zeros_flag(1, 1); | |||
| zeros_flag = to_matrix_cl(zero_on_diagonal_flag); | |||
| matrix_cl<int> zeros_flag = constant(0, 1, 1); | |||
There was a problem hiding this comment.
[optional] This looks good, but we could completely replace this function with kernel generator implementation.
Co-authored-by: Tadej Ciglarič <[email protected]>
…4.1 (tags/RELEASE_600/final)
t4c1
reviewed
Dec 9, 2020
Co-authored-by: Tadej Ciglarič <[email protected]>
t4c1
previously approved these changes
Dec 9, 2020
…4.1 (tags/RELEASE_600/final)
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
t4c1
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR does the following:
Tests
All new functions have them, add/subtract now use the utility function.
Side Effects
/
Release notes
OpenCL: added prim support for add_diag(), diag_matrix(), subtract(), inv_cloglog() and clenead up superseded kernels/functions zeros and fill.
Checklist
Math issue Implement matrix_cl overloads for prim & rev functions #1854
Copyright holder: Rok Češnovar, Uni. of Ljubljana
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)