Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix OpenCL test util #2187

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

t4c1
Copy link
Contributor

@t4c1 t4c1 commented Nov 11, 2020

Summary

Lately we had some random OpenCL test failures in PRs that did not touch the stuff tests were failing for. The error is nondeterministic and rare, so I failed to reproduce it. But looking at the code I believe the reason is we could get some dangling references. Hopefully this will fix the issue.

Tests

This is fixing tests.

Side Effects

None.

Checklist

  • Math issue #(issue number)

  • Copyright holder: Tadej Ciglarič

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@rok-cesnovar rok-cesnovar self-requested a review November 11, 2020 11:26
Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge when tests pass. The math side of things passed so this is good to go.

Only time will tell if this was the only cause for the sporadic test issue. Fingers crossed.

@stan-buildbot
Copy link
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 3.02 2.98 1.01 1.12% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 0.99 -1.06% slower
eight_schools/eight_schools.stan 0.11 0.12 1.0 -0.47% slower
gp_regr/gp_regr.stan 0.17 0.17 0.98 -1.87% slower
irt_2pl/irt_2pl.stan 5.68 5.66 1.0 0.37% faster
performance.compilation 87.67 85.33 1.03 2.67% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 8.47 8.8 0.96 -3.9% slower
pkpd/one_comp_mm_elim_abs.stan 30.29 29.87 1.01 1.38% faster
sir/sir.stan 133.33 134.63 0.99 -0.98% slower
gp_regr/gen_gp_data.stan 0.04 0.04 1.0 -0.2% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 2.97 2.96 1.0 0.22% faster
pkpd/sim_one_comp_mm_elim_abs.stan 0.38 0.39 1.0 -0.32% slower
arK/arK.stan 1.8 1.77 1.01 1.24% faster
arma/arma.stan 0.6 0.6 1.0 0.43% faster
garch/garch.stan 0.74 0.75 0.99 -1.49% slower
Mean result: 0.998326875864

Jenkins Console Log
Blue Ocean
Commit hash: e6216e8


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@rok-cesnovar rok-cesnovar merged commit 1b3feb7 into stan-dev:develop Nov 12, 2020
@rok-cesnovar rok-cesnovar deleted the bugfix_opencl_test_util branch November 12, 2020 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants