-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opencl gamma_lpdf and gumbel_lpdf #2185
Conversation
…4.1 (tags/RELEASE_600/final)
…into opencl_gamma_lpdf
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
# Conflicts: # stan/math/opencl/opencl.hpp
…into opencl_gamma_lpdf
# Conflicts: # stan/math/opencl/opencl.hpp
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Summary
Adds OpenCL implementations for functions
gamma_lpdf
andgumbel_lpdf
.Also fixes a bug in
check_cl
, which in case of throwing an exception, caused it to report wrong indices of error.Tests
New functions adre tested.
Side Effects
None.
Release notes
Added OpenCL implementations for functions
gamma_lpdf
andgumbel_lpdf
.Fixed a bug in
check_cl
, which in case of throwing an exception, caused it to report wrong indices of error.Checklist
Math issue Add OpenCL distributions #2152
Copyright holder: Tadej Ciglarič
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit
)make test-headers
)make test-math-dependencies
)make doxygen
)make cpplint
)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested