Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generalize Weibull #2136

Merged
merged 4 commits into from
Oct 26, 2020
Merged

generalize Weibull #2136

merged 4 commits into from
Oct 26, 2020

Conversation

t4c1
Copy link
Contributor

@t4c1 t4c1 commented Oct 7, 2020

Summary

Generalizes Weibull distribution related functions to accept Eigen expressions.

Tests

Tested using expression testing framework.

Side Effects

None.

Release notes

Generalized Weibull distribution related functions to accept Eigen expressions.

Checklist

  • Math issue Generalize matrix function signatures #1470

  • Copyright holder: Tadej Ciglarič

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

Copy link
Member

@bbbales2 bbbales2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright. I see some juicy log(x / y) s. Waiting on tests.

@stan-buildbot
Copy link
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 3.12 3.17 0.98 -1.56% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 0.99 -0.94% slower
eight_schools/eight_schools.stan 0.12 0.12 0.98 -1.89% slower
gp_regr/gp_regr.stan 0.17 0.17 1.0 0.03% faster
irt_2pl/irt_2pl.stan 5.68 5.64 1.01 0.7% faster
performance.compilation 92.26 89.28 1.03 3.23% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 9.2 9.37 0.98 -1.92% slower
pkpd/one_comp_mm_elim_abs.stan 29.85 30.07 0.99 -0.75% slower
sir/sir.stan 130.11 127.68 1.02 1.87% faster
gp_regr/gen_gp_data.stan 0.05 0.04 1.03 2.64% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.19 3.17 1.01 0.78% faster
pkpd/sim_one_comp_mm_elim_abs.stan 0.37 0.38 0.97 -3.02% slower
arK/arK.stan 1.83 1.83 1.0 0.02% faster
arma/arma.stan 0.75 0.76 0.99 -1.45% slower
garch/garch.stan 0.63 0.63 1.01 0.85% faster
Mean result: 0.999370383662

Jenkins Console Log
Blue Ocean
Commit hash: dda70bb


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@bbbales2
Copy link
Member

bbbales2 commented Oct 9, 2020

Conflicts!

t4c1 added 2 commits October 12, 2020 09:34
# Conflicts:
#	test/expressions/stan_math_sigs_exceptions.expected
# Conflicts:
#	test/expressions/stan_math_sigs_exceptions.expected
@stan-buildbot
Copy link
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 3.06 3.16 0.97 -3.12% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 1.01 0.72% faster
eight_schools/eight_schools.stan 0.11 0.12 0.99 -1.06% slower
gp_regr/gp_regr.stan 0.18 0.17 1.01 1.34% faster
irt_2pl/irt_2pl.stan 5.72 5.68 1.01 0.77% faster
performance.compilation 89.71 88.65 1.01 1.19% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 8.85 8.45 1.05 4.48% faster
pkpd/one_comp_mm_elim_abs.stan 28.64 29.46 0.97 -2.86% slower
sir/sir.stan 134.97 128.34 1.05 4.91% faster
gp_regr/gen_gp_data.stan 0.04 0.04 0.99 -1.19% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.1 3.03 1.02 2.37% faster
pkpd/sim_one_comp_mm_elim_abs.stan 0.39 0.38 1.02 2.23% faster
arK/arK.stan 1.82 1.8 1.01 1.14% faster
arma/arma.stan 0.76 0.6 1.26 20.82% faster
garch/garch.stan 0.55 0.7 0.78 -27.88% slower
Mean result: 1.01082448012

Jenkins Console Log
Blue Ocean
Commit hash: 3473789


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Copy link
Member

@bbbales2 bbbales2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, merge on the 20th, after the feature freeze

@bbbales2 bbbales2 merged commit 18dbb5b into stan-dev:develop Oct 26, 2020
@rok-cesnovar rok-cesnovar deleted the generalize_weibull branch October 26, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants