Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update page on external C++ #626

Merged
merged 5 commits into from
Mar 23, 2023
Merged

Update page on external C++ #626

merged 5 commits into from
Mar 23, 2023

Conversation

WardBrian
Copy link
Member

Submission Checklist

  • Builds locally
  • New functions marked with `r since("VERSION")`
  • Declare copyright holder and open-source license: see below

Summary

External C++ has become easier to use since stan-dev/stanc3#1277. This updates our documentation to reflect the changes:

  • Stanc3 no longer generates a forward declaration for external functions, closing External c++ example fails cmdstan#1119
  • As a result, functions could now be declared either in the model namespace or in the global namespace inside the header
  • It is now significantly easier to write a reverse-mode specialization. I have added an example of this based on the Math documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian WardBrian linked an issue Mar 23, 2023 that may be closed by this pull request
@WardBrian WardBrian requested a review from andrjohns March 23, 2023 19:23
Copy link
Contributor

@andrjohns andrjohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple of suggestions

@WardBrian WardBrian requested a review from andrjohns March 23, 2023 19:27
Copy link
Contributor

@andrjohns andrjohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for getting all this working!

@WardBrian
Copy link
Member Author

It was mostly @nhuurre doing the stanc work that fixed this up, I just remembered we never wrote it down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External c++ example fails
2 participants