Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle tilde ~ in model paths. #671

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Conversation

tillahoffmann
Copy link
Contributor

Apple uses tildes in some paths for files that are synced through iCloud (see here, for example). It's of course a somewhat questionable choice. This PR allows models in these iCloud folders to be compiled and used.

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Harvard University

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2023

Codecov Report

Merging #671 (5b1a3f8) into develop (452e8ef) will increase coverage by 0.13%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #671      +/-   ##
===========================================
+ Coverage    80.92%   81.06%   +0.13%     
===========================================
  Files           69       69              
  Lines        10653    10677      +24     
===========================================
+ Hits          8621     8655      +34     
+ Misses        2032     2022      -10     

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@WardBrian WardBrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small comments, but more generally the Windows failures are obviously the bigger issue here. ~ is used on Windows for "short paths": https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file?redirectedfrom=MSDN#short-vs-long-names

@tillahoffmann
Copy link
Contributor Author

tillahoffmann commented Jun 13, 2023

the Windows failures are obviously the bigger issue here.

Seems like we could just skip handling ~ on Windows given that it seems to be happy with tildes anyway. I'll make the appropriate changes.

Edit: Sorry for the noise; I don't have a Windows machine to test on locally.

@ahartikainen
Copy link
Contributor

Maybe pytest skipif for Windows is enough for the tests.

@tillahoffmann tillahoffmann force-pushed the tilde branch 2 times, most recently from fc5b9e3 to b153cc9 Compare June 19, 2023 21:19
@WardBrian WardBrian merged commit 1361f35 into stan-dev:develop Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants