-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle tilde ~
in model paths.
#671
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #671 +/- ##
===========================================
+ Coverage 80.92% 81.06% +0.13%
===========================================
Files 69 69
Lines 10653 10677 +24
===========================================
+ Hits 8621 8655 +34
+ Misses 2032 2022 -10 see 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple small comments, but more generally the Windows failures are obviously the bigger issue here. ~
is used on Windows for "short paths": https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file?redirectedfrom=MSDN#short-vs-long-names
Seems like we could just skip handling Edit: Sorry for the noise; I don't have a Windows machine to test on locally. |
Maybe pytest skipif for Windows is enough for the tests. |
fc5b9e3
to
b153cc9
Compare
Apple uses tildes in some paths for files that are synced through iCloud (see here, for example). It's of course a somewhat questionable choice. This PR allows models in these iCloud folders to be compiled and used.
Submission Checklist
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Harvard University
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: