Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat and adjust requirements to get CI builds passing again #15

Merged
merged 13 commits into from
Jan 19, 2022
Merged

Reformat and adjust requirements to get CI builds passing again #15

merged 13 commits into from
Jan 19, 2022

Conversation

sgillies
Copy link
Collaborator

@sgillies sgillies commented Jan 18, 2022 •
edited
Loading

There have been some upstream changes since this project was last tested. This PR gets things back in working order.

sgillies
sgillies commented Jan 18, 2022
View reviewed changes
sgillies
sgillies commented Jan 18, 2022
View reviewed changes
sgillies
sgillies commented Jan 18, 2022
View reviewed changes
@sgillies sgillies added this to the 0.2.0 milestone Jan 18, 2022
@sgillies sgillies added the bug Something isn't working label Jan 18, 2022
@sgillies sgillies marked this pull request as ready for review January 18, 2022 20:05
@sgillies
Copy link
Collaborator Author

sgillies commented Jan 18, 2022 •
edited
Loading

Ah, the stactools version was pinned because we can't get a GDAL binary package to use for testing? I think the best approach is to pin it in requirements-dev.txt, only until the GDAL python bindings are removed as a dependency.

sgillies
sgillies commented Jan 18, 2022
View reviewed changes
sgillies
sgillies commented Jan 18, 2022
View reviewed changes
@sgillies sgillies requested a review from gadomski January 18, 2022 20:55
@sgillies
Copy link
Collaborator Author

sgillies commented Jan 18, 2022 •
edited
Loading

Review please @gadomski ? 🙏 (no rush!)

@sgillies sgillies mentioned this pull request Jan 18, 2022
Merged
gadomski
gadomski requested changes Jan 19, 2022
View reviewed changes
gadomski
gadomski approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the iterations, and sorry for the rough edges :-).

@sgillies sgillies merged commit b0c7d28 into stactools-packages:main Jan 19, 2022
@sgillies sgillies deleted the yapf-0.32 branch January 19, 2022 18:27
@duckontheweb duckontheweb mentioned this pull request Jan 19, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadomski gadomski gadomski approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sgillies @gadomski