fix(stackable-versioned)!: Emit an error when invalid items are added to the versioned module #1059
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to the versioned module
NickLarsenNZ
moved this from Development: Waiting for Review
to Development: Done
in Stackable Engineering
|
Nice, thanks! |
Ah yeah, I missed the changelog, but I don't see how it is a breaking change. It was broken (because any unsupported code defined there was thrown away, and therefore unused/unusable). Now we get a warning/error. Edit: I guess the breaking part is that unsupported items accidentally added in the module can now cause a compilation failure. Done in #1062 |
NickLarsenNZ
changed the title
|
exactly, previously compiling code is now not compiling any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves DX by emitting an error when invalid items are added to the versioned module: