Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: fix for hpp-fcl/coal v3 #2591

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Conversation

nim65s
Copy link
Contributor

@nim65s nim65s commented Feb 22, 2025

Fix, at least on ROS buildfarm:

-- hpp-fcl FOUND. hpp-fcl at /opt/ros/rolling/lib/x86_64-linux-gnu/libhpp-fcl.so
-- Found Boost: /usr/include (found version "1.83.0") found components: chrono serialization filesystem
CMake Error at /opt/ros/rolling/lib/x86_64-linux-gnu/cmake/hpp-fcl/hpp-fclConfig.cmake:181 (message):
  hpp-fcl: hpp-fcl >= 2.1.2 not found.
Call Stack (most recent call first):
  cmake/package-config.cmake:133 (find_package)
  CMakeLists.txt:341 (add_project_dependency)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:

  • build_collision (build Pinocchio with coal support)
  • build_casadi (build Pinocchio with CasADi support)
  • build_autodiff (build Pinocchio with CppAD support)
  • build_codegen (build Pinocchio with CppADCodeGen support)
  • build_extra (build Pinocchio with extra algorithms)
  • build_mpfr (build Pinocchio with Boost.Multiprecision support)
  • build_sdf (build Pinocchio with SDF parser)
  • build_accelerate (build Pinocchio with APPLE Accelerate framework support)
  • build_all (build Pinocchio with ALL the options stated above)

Thanks.
The Pinocchio development team.

@MaximilienNaveau
Copy link

should we change on ros build farm in the package.xml the hpp-fcl to coal?
feels like it would fit into this PR as well?

@nim65s
Copy link
Contributor Author

nim65s commented Mar 5, 2025

no, on ROS, coal does not have the compatibilty option, because we should not have two apt packages installing the same files. So we must wait for pinocchio v4 to be properly compatible with coal.

Fix, at least on ROS buildfarm:
```
-- hpp-fcl FOUND. hpp-fcl at /opt/ros/rolling/lib/x86_64-linux-gnu/libhpp-fcl.so
-- Found Boost: /usr/include (found version "1.83.0") found components: chrono serialization filesystem
CMake Error at /opt/ros/rolling/lib/x86_64-linux-gnu/cmake/hpp-fcl/hpp-fclConfig.cmake:181 (message):
  hpp-fcl: hpp-fcl >= 2.1.2 not found.
Call Stack (most recent call first):
  cmake/package-config.cmake:133 (find_package)
  CMakeLists.txt:341 (add_project_dependency)
```
@jcarpent jcarpent merged commit d97e3df into stack-of-tasks:devel Mar 5, 2025
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants