Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any number of arguments that are strings #203

Conversation

jmclean-cnexus
Copy link

Update Typings for FilterFunction to reflect usage on https://squirrelly.js.org/docs/api/filter-api, allowing multiple input args.

@nebrelbug
Copy link
Collaborator

@jmclean-cnexus thanks for the PR!

Copy link
Collaborator

@nebrelbug nebrelbug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! If you could just update based on my comment, that would be perfect.

@jmclean-cnexus
Copy link
Author

@nebrelbug anything else i can do to the PR to get it to merge. BTW...thanks for such an awesome module; I think ill be using/recommending it for many of my future solutions.

@nebrelbug
Copy link
Collaborator

@jmclean-cnexus this looks great! I'll merge now 🎉.

BTW...thanks for such an awesome module; I think ill be using/recommending it for many of my future solutions.

Thank you! I'm glad you enjoy it!

By the way, is it alright if I add you to the README as a contributor?

@nebrelbug nebrelbug merged commit db7ef0f into squirrellyjs:master Sep 9, 2020
@jmclean-cnexus
Copy link
Author

I would be proud to be on the readme, and will hopefully provide more quality PRs in the future!

@nebrelbug
Copy link
Collaborator

@jmclean-cnexus awesome! I hope you can!

@all-contributors please add @jmclean-cnexus for his coding contributions 🎉

@allcontributors
Copy link
Contributor

@nebrelbug

I've put up a pull request to add @jmclean-cnexus! 🎉

@nebrelbug
Copy link
Collaborator

@jmclean-cnexus just added you 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants