Remove unnecessary AUTOINCREMENT from example
#1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstly, thanks for the great project. According to (the sqlite documentation)[https://www.sqlite.org/autoinc.html], the `AUTOINCREMENT` keyword shouldn't be used in normal cases: > The AUTOINCREMENT keyword imposes extra CPU, memory, disk space, and disk I/O overhead and should be avoided if not strictly needed. *It is usually not needed*. > On an INSERT, if the ROWID or INTEGER PRIMARY KEY column is not explicitly given a value, then it will be filled automatically with an unused integer, usually one more than the largest ROWID currently in use. *This is true regardless of whether or not the AUTOINCREMENT keyword is used*.
akutschera
pushed a commit
to akutschera/sqlc
that referenced
this pull request
Nov 10, 2022
Firstly, thanks for the great project. According to (the sqlite documentation)[https://www.sqlite.org/autoinc.html], the `AUTOINCREMENT` keyword shouldn't be used in normal cases: > The AUTOINCREMENT keyword imposes extra CPU, memory, disk space, and disk I/O overhead and should be avoided if not strictly needed. *It is usually not needed*. > On an INSERT, if the ROWID or INTEGER PRIMARY KEY column is not explicitly given a value, then it will be filled automatically with an unused integer, usually one more than the largest ROWID currently in use. *This is true regardless of whether or not the AUTOINCREMENT keyword is used*.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, thanks for the great project.
According to the sqlite documentation, the
AUTOINCREMENTkeyword shouldn't be used in normal cases: