fix: named params contribute to batch parameter count #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleconroy
reviewed
Sep 9, 2022
internal/sql/validate/cmd.go
Outdated
Comment on lines
50
to
54
| namedFunc := astutils.Search(n, named.IsParamFunc) | ||
| namedSign := astutils.Search(n, named.IsParamSign) | ||
| if len(namedFunc.Items)+len(namedSign.Items) > 0 { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
As some point, we rewrite the AST to change named parameters into normal parameter references. We probably just want to move the validate batch call so that it happens after that process. Then it doesn't need to know anything about named parameters.
kyleconroy
approved these changes
Sep 14, 2022
chrisyxlee
force-pushed
the
chris/batch-named
branch
from
a1ae9c0 to
5ffeed0
Compare
|
merge conflicts with myself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The batch validation code was only allowing numbered params contribute to the total parameter count of a query, which prevented batch queries with only named parameters from successfully generating code.
Fixes #1625